aboutsummaryrefslogtreecommitdiff
path: root/dump.c
diff options
context:
space:
mode:
authorCornelia Huck <cohuck@redhat.com>2017-09-13 16:20:35 +0200
committerDr. David Alan Gilbert <dgilbert@redhat.com>2017-09-14 15:52:10 +0100
commitd1e6994abcd12c7f54aa73ff848fb6215c783898 (patch)
tree1cc2ee843f45f28b4847c8dbf85c1369484d85fb /dump.c
parent6dba634097d54db60017f10c160a052e46bdf60d (diff)
downloadqemu-d1e6994abcd12c7f54aa73ff848fb6215c783898.zip
qemu-d1e6994abcd12c7f54aa73ff848fb6215c783898.tar.gz
qemu-d1e6994abcd12c7f54aa73ff848fb6215c783898.tar.bz2
dump: do not dump non-existent guest memory
It does not really make sense to dump memory that is not there. Moreover, that fixes a segmentation fault when calling dump-guest-memory with no filter for a machine with no memory defined. New behaviour is: (qemu) dump-guest-memory /dev/null dump: no guest memory to dump (qemu) dump-guest-memory /dev/null 0 4096 dump: no guest memory to dump Signed-off-by: Cornelia Huck <cohuck@redhat.com> Tested-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Laurent Vivier <lvivier@redhat.com> Reviewed-by: Greg Kurz <groug@kaod.org> Reviewed-by: Peter Xu <peterx@redhat.com> Message-Id: <20170913142036.2469-4-lvivier@redhat.com> Signed-off-by: Laurent Vivier <lvivier@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'dump.c')
-rw-r--r--dump.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/dump.c b/dump.c
index a79773d..d2093e1 100644
--- a/dump.c
+++ b/dump.c
@@ -1536,6 +1536,12 @@ static void dump_init(DumpState *s, int fd, bool has_format,
fprintf(stderr, "DUMP: total memory to dump: %lu\n", s->total_size);
#endif
+ /* it does not make sense to dump non-existent memory */
+ if (!s->total_size) {
+ error_setg(errp, "dump: no guest memory to dump");
+ goto cleanup;
+ }
+
s->start = get_start_block(s);
if (s->start == -1) {
error_setg(errp, QERR_INVALID_PARAMETER, "begin");