diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2016-09-12 13:19:04 +0400 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2016-09-19 17:32:21 +0200 |
| commit | c823501ea9bf7b13ca32226e1c628480edb034d6 (patch) | |
| tree | 18d5450db5e2bac1101ea692847e22f638d5f77d /docs/writing-qmp-commands.txt | |
| parent | b804dc3bcddce6d0cd58e3c66cb0ee5b282b9e14 (diff) | |
| download | qemu-c823501ea9bf7b13ca32226e1c628480edb034d6.zip qemu-c823501ea9bf7b13ca32226e1c628480edb034d6.tar.gz qemu-c823501ea9bf7b13ca32226e1c628480edb034d6.tar.bz2 | |
monitor: use qmp_find_command() (using generated qapi code)
Stop using the so-called 'middle' mode. Instead, use qmp_find_command()
from generated qapi commands registry. Update and fix the documentation
too.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20160912091913.15831-10-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'docs/writing-qmp-commands.txt')
| -rw-r--r-- | docs/writing-qmp-commands.txt | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt index 59aa77a..0a66e0e 100644 --- a/docs/writing-qmp-commands.txt +++ b/docs/writing-qmp-commands.txt @@ -127,7 +127,6 @@ following at the bottom: { .name = "hello-world", .args_type = "", - .mhandler.cmd_new = qmp_marshal_hello_world, }, You're done. Now build qemu, run it as suggested in the "Testing" section, @@ -179,7 +178,6 @@ The last step is to update the qmp-commands.hx file: { .name = "hello-world", .args_type = "message:s?", - .mhandler.cmd_new = qmp_marshal_hello_world, }, Notice that the "args_type" member got our "message" argument. The character @@ -454,12 +452,11 @@ There are a number of things to be noticed: 6. You have to include the "qmp-commands.h" header file in qemu-timer.c, otherwise qemu won't build -The last step is to add the correspoding entry in the qmp-commands.hx file: +The last step is to add the corresponding entry in the qmp-commands.hx file: { .name = "query-alarm-clock", .args_type = "", - .mhandler.cmd_new = qmp_marshal_query_alarm_clock, }, Time to test the new command. Build qemu, run it as described in the "Testing" @@ -518,7 +515,7 @@ in the monitor.c file. The entry for the "info alarmclock" follows: .args_type = "", .params = "", .help = "show information about the alarm clock", - .mhandler.info = hmp_info_alarm_clock, + .mhandler.cmd = hmp_info_alarm_clock, }, To test this, run qemu and type "info alarmclock" in the user monitor. @@ -605,7 +602,6 @@ To test this you have to add the corresponding qmp-commands.hx entry: { .name = "query-alarm-methods", .args_type = "", - .mhandler.cmd_new = qmp_marshal_query_alarm_methods, }, Now Build qemu, run it as explained in the "Testing" section and try our new |