aboutsummaryrefslogtreecommitdiff
path: root/docs/devel/secure-coding-practices.rst
diff options
context:
space:
mode:
authorKlaus Jensen <k.jensen@samsung.com>2021-01-18 07:31:45 +0100
committerKlaus Jensen <k.jensen@samsung.com>2021-02-08 21:15:53 +0100
commit0d3d5da2ccc8823c7c904b790b8d0fdf569790f0 (patch)
tree8d332dfff345f0459bf6cb82dc7c46b5dec5a0a9 /docs/devel/secure-coding-practices.rst
parentffacaf090893c5d6a5a6ea51b93087411af859c4 (diff)
downloadqemu-0d3d5da2ccc8823c7c904b790b8d0fdf569790f0.zip
qemu-0d3d5da2ccc8823c7c904b790b8d0fdf569790f0.tar.gz
qemu-0d3d5da2ccc8823c7c904b790b8d0fdf569790f0.tar.bz2
hw/block/nvme: fix 64 bit register hi/lo split writes
64 bit registers like ASQ and ACQ should be writable by both a hi/lo 32 bit write combination as well as a plain 64 bit write. The spec does not define ordering on the hi/lo split, but the code currently assumes that the low order bits are written first. Additionally, the code does not consider that another address might already have been written into the register, causing the OR'ing to result in a bad address. Fix this by explicitly overwriting only the low or high order bits for 32 bit writes. Signed-off-by: Klaus Jensen <k.jensen@samsung.com> Reviewed-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'docs/devel/secure-coding-practices.rst')
0 files changed, 0 insertions, 0 deletions