diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-02-26 17:21:13 +0100 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2015-03-01 12:37:54 +0100 |
| commit | f51074cdc6e750daa3b6df727d83449a7e42b391 (patch) | |
| tree | 87af0f83b6e5b4c9e093e5e312b6aa5e6fae5073 /device-hotplug.c | |
| parent | 6dbcb81956b16d794c9c0257b94bd4c6feba713f (diff) | |
| download | qemu-f51074cdc6e750daa3b6df727d83449a7e42b391.zip qemu-f51074cdc6e750daa3b6df727d83449a7e42b391.tar.gz qemu-f51074cdc6e750daa3b6df727d83449a7e42b391.tar.bz2 | |
pci-hotplug-old: Has been dead for five major releases, bury
Commit 79ca616 (v1.6.0) accidentally disabled legacy x86-only HMP
commands pci_add, pci_del: it defined CONFIG_PCI_HOTPLUG only as make
variable, not as preprocessor macro, killing the code conditional on
defined(CONFIG_PCI_HOTPLUG_OLD).
In all this time, nobody reported the loss. I only noticed it when I
tried to test some error reporting change that forced me to touch this
old crap again.
Fun: git-log hw/pci/pci-hotplug-old.c shows our faith in the backward
compatibility god has been strong enough to sacrifice at its altar
about a dozen times, but not strong enough to even once verify the
legacy feature's still there, let alone works.
Remove the commands along with the code backing them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'device-hotplug.c')
| -rw-r--r-- | device-hotplug.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/device-hotplug.c b/device-hotplug.c index 833d874..68b9496 100644 --- a/device-hotplug.c +++ b/device-hotplug.c @@ -30,7 +30,7 @@ #include "sysemu/sysemu.h" #include "monitor/monitor.h" -DriveInfo *add_init_drive(const char *optstr) +static DriveInfo *add_init_drive(const char *optstr) { DriveInfo *dinfo; QemuOpts *opts; @@ -69,9 +69,8 @@ void hmp_drive_add(Monitor *mon, const QDict *qdict) monitor_printf(mon, "OK\n"); break; default: - if (pci_drive_hot_add(mon, qdict, dinfo)) { - goto err; - } + monitor_printf(mon, "Can't hot-add drive to type %d\n", dinfo->type); + goto err; } return; |