aboutsummaryrefslogtreecommitdiff
path: root/chardev/spice.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2020-02-14 17:17:10 +0000
committerStefan Hajnoczi <stefanha@redhat.com>2020-02-22 08:26:47 +0000
commit195ed8cb365edeb0d0a70a2ffdeb7a073f9a8117 (patch)
tree5178e83f699e90927825a009012c9ff17047c12c /chardev/spice.c
parentca8c6b22754b0f17818b1d1910d31f0aa1a49cc7 (diff)
downloadqemu-195ed8cb365edeb0d0a70a2ffdeb7a073f9a8117.zip
qemu-195ed8cb365edeb0d0a70a2ffdeb7a073f9a8117.tar.gz
qemu-195ed8cb365edeb0d0a70a2ffdeb7a073f9a8117.tar.bz2
qemu/queue.h: add QLIST_SAFE_REMOVE()
QLIST_REMOVE() assumes the element is in a list. It also leaves the element's linked list pointers dangling. Introduce a safe version of QLIST_REMOVE() and convert open-coded instances of this pattern. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Sergio Lopez <slp@redhat.com> Message-id: 20200214171712.541358-4-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'chardev/spice.c')
-rw-r--r--chardev/spice.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/chardev/spice.c b/chardev/spice.c
index 241e2b7..bf7ea1e 100644
--- a/chardev/spice.c
+++ b/chardev/spice.c
@@ -216,9 +216,7 @@ static void char_spice_finalize(Object *obj)
vmc_unregister_interface(s);
- if (s->next.le_prev) {
- QLIST_REMOVE(s, next);
- }
+ QLIST_SAFE_REMOVE(s, next);
g_free((char *)s->sin.subtype);
g_free((char *)s->sin.portname);