aboutsummaryrefslogtreecommitdiff
path: root/chardev/char-file.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2022-11-04 17:06:53 +0100
committerMarkus Armbruster <armbru@redhat.com>2022-12-14 20:04:47 +0100
commit8de69efab1009d374c7f01d2536797ea009ee796 (patch)
tree96f1ad0bd5b4f19fc484cee4c4782349a0546fa2 /chardev/char-file.c
parent54fde4ff0621c22b15cbaaa3c74301cc0dbd1c9e (diff)
downloadqemu-8de69efab1009d374c7f01d2536797ea009ee796.zip
qemu-8de69efab1009d374c7f01d2536797ea009ee796.tar.gz
qemu-8de69efab1009d374c7f01d2536797ea009ee796.tar.bz2
qapi chardev: Elide redundant has_FOO in generated C
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/char.json. Said commit explains the transformation in more detail. The invariant violations mentioned there do not occur here. Cc: Marc-André Lureau <marcandre.lureau@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20221104160712.3005652-12-armbru@redhat.com>
Diffstat (limited to 'chardev/char-file.c')
-rw-r--r--chardev/char-file.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/chardev/char-file.c b/chardev/char-file.c
index 2fd8070..3a7b9ca 100644
--- a/chardev/char-file.c
+++ b/chardev/char-file.c
@@ -45,7 +45,7 @@ static void qmp_chardev_open_file(Chardev *chr,
DWORD accessmode;
DWORD flags;
- if (file->has_in) {
+ if (file->in) {
error_setg(errp, "input file not supported");
return;
}
@@ -83,7 +83,7 @@ static void qmp_chardev_open_file(Chardev *chr,
return;
}
- if (file->has_in) {
+ if (file->in) {
flags = O_RDONLY;
in = qmp_chardev_open_file_source(file->in, flags, errp);
if (in < 0) {