aboutsummaryrefslogtreecommitdiff
path: root/blockdev.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2014-11-21 10:48:58 +0000
committerKevin Wolf <kwolf@redhat.com>2014-12-10 10:31:13 +0100
commit73f1f7564d58963fc692334bcf0c529e1e3536fb (patch)
treebe3b5a7356cfcc26e397a5ba716c0ffae11503f6 /blockdev.c
parentb756b9ce8a81cd0d95ae691cee541a149463c8c9 (diff)
downloadqemu-73f1f7564d58963fc692334bcf0c529e1e3536fb.zip
qemu-73f1f7564d58963fc692334bcf0c529e1e3536fb.tar.gz
qemu-73f1f7564d58963fc692334bcf0c529e1e3536fb.tar.bz2
blockdev: drop unnecessary DriveBackupState field assignment
drive_backup_prepare() assigns DriveBackupState fields to NULL in the error path. This is unnecessary because the DriveBackupState is allocated using g_malloc0() and other functions like external_snapshot_prepare() already rely on this. Do not explicitly assign fields to NULL so that the error path is concise and does not require modification when fields are added to DriveBackupState. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Message-id: 1416566940-4430-3-git-send-email-stefanha@redhat.com Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
-rw-r--r--blockdev.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/blockdev.c b/blockdev.c
index 490f698..b58ce30 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1489,8 +1489,6 @@ static void drive_backup_prepare(BlkTransactionState *common, Error **errp)
&local_err);
if (local_err) {
error_propagate(errp, local_err);
- state->bs = NULL;
- state->job = NULL;
return;
}