aboutsummaryrefslogtreecommitdiff
path: root/blockdev.c
diff options
context:
space:
mode:
authorVishvananda Ishaya <vishvananda@gmail.com>2013-01-24 10:00:40 -0800
committerKevin Wolf <kwolf@redhat.com>2013-01-25 18:18:36 +0100
commit8689907266b649b757c2203d9652cbe928a3ae0b (patch)
tree765ca571cc265cfbcdc0a138c4eda9f8c15efc93 /blockdev.c
parenta26230218d7d66ec5cb1aec101ceaf0e7400ef7f (diff)
downloadqemu-8689907266b649b757c2203d9652cbe928a3ae0b.zip
qemu-8689907266b649b757c2203d9652cbe928a3ae0b.tar.gz
qemu-8689907266b649b757c2203d9652cbe928a3ae0b.tar.bz2
block: Create proper size file for disk mirror
The qmp monitor command to mirror a disk was passing -1 for size along with the disk's backing file. This size of the resulting disk is the size of the backing file, which is incorrect if the disk has been resized. Therefore we should always pass in the size of the current disk. Signed-off-by: Vishvananda Ishaya <vishvananda@gmail.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev.c')
-rw-r--r--blockdev.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/blockdev.c b/blockdev.c
index ac396f3..fdc573f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1282,11 +1282,11 @@ void qmp_drive_mirror(const char *device, const char *target,
return;
}
+ bdrv_get_geometry(bs, &size);
+ size *= 512;
if (sync == MIRROR_SYNC_MODE_FULL && mode != NEW_IMAGE_MODE_EXISTING) {
/* create new image w/o backing file */
assert(format && drv);
- bdrv_get_geometry(bs, &size);
- size *= 512;
bdrv_img_create(target, format,
NULL, NULL, NULL, size, flags, &local_err);
} else {
@@ -1299,7 +1299,7 @@ void qmp_drive_mirror(const char *device, const char *target,
bdrv_img_create(target, format,
source->filename,
source->drv->format_name,
- NULL, -1, flags, &local_err);
+ NULL, size, flags, &local_err);
break;
default:
abort();