diff options
| author | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2012-04-25 16:51:01 +0100 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2012-04-27 11:44:50 -0300 |
| commit | 9e6636c72d8d6f0605e23ed820c8487686882b12 (patch) | |
| tree | bc01d69b62e17c29e100979172b3f10fd2d13bdf /block_int.h | |
| parent | fd7f8c65377ee918479e43b38d44f54f13aa6548 (diff) | |
| download | qemu-9e6636c72d8d6f0605e23ed820c8487686882b12.zip qemu-9e6636c72d8d6f0605e23ed820c8487686882b12.tar.gz qemu-9e6636c72d8d6f0605e23ed820c8487686882b12.tar.bz2 | |
block: use Error mechanism instead of -errno for block_job_set_speed()
There are at least two different errors that can occur in
block_job_set_speed(): the job might not support setting speeds or the
value might be invalid.
Use the Error mechanism to report the error where it occurs.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'block_int.h')
| -rw-r--r-- | block_int.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/block_int.h b/block_int.h index e70a33e..e042676 100644 --- a/block_int.h +++ b/block_int.h @@ -79,7 +79,7 @@ typedef struct BlockJobType { const char *job_type; /** Optional callback for job types that support setting a speed limit */ - int (*set_speed)(BlockJob *job, int64_t value); + void (*set_speed)(BlockJob *job, int64_t value, Error **errp); } BlockJobType; /** @@ -375,11 +375,12 @@ void block_job_complete(BlockJob *job, int ret); * block_job_set_speed: * @job: The job to set the speed for. * @speed: The new value + * @errp: Error object. * * Set a rate-limiting parameter for the job; the actual meaning may * vary depending on the job type. */ -int block_job_set_speed(BlockJob *job, int64_t value); +void block_job_set_speed(BlockJob *job, int64_t value, Error **errp); /** * block_job_cancel: |