aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorHanna Reitz <hreitz@redhat.com>2021-10-11 17:50:31 +0200
committerEric Blake <eblake@redhat.com>2021-10-15 15:39:38 -0500
commite7e588d432d31ecebc26358e47201dd108db964c (patch)
tree9f3f035f969a731e94ee163fa1e9e899f13a7011 /block
parent253e399bab7c83b3411f8eac01840283a9304cb3 (diff)
downloadqemu-e7e588d432d31ecebc26358e47201dd108db964c.zip
qemu-e7e588d432d31ecebc26358e47201dd108db964c.tar.gz
qemu-e7e588d432d31ecebc26358e47201dd108db964c.tar.bz2
qcow2: Silence clang -m32 compiler warning
With -m32, size_t is generally only a uint32_t. That makes clang complain that in the assertion assert(qiov->size <= INT64_MAX); the range of the type of qiov->size (size_t) is too small for any of its values to ever exceed INT64_MAX. Cast qiov->size to uint64_t to silence clang. Fixes: f7ef38dd1310d7d9db76d0aa16899cbc5744f36d ("block: use int64_t instead of uint64_t in driver read handlers") Signed-off-by: Hanna Reitz <hreitz@redhat.com> Message-Id: <20211011155031.149158-1-hreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/qcow2-cluster.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 5727f92..21884a1 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -513,7 +513,8 @@ static int coroutine_fn do_perform_cow_read(BlockDriverState *bs,
*/
assert(src_cluster_offset <= INT64_MAX);
assert(src_cluster_offset + offset_in_cluster <= INT64_MAX);
- assert(qiov->size <= INT64_MAX);
+ /* Cast qiov->size to uint64_t to silence a compiler warning on -m32 */
+ assert((uint64_t)qiov->size <= INT64_MAX);
bdrv_check_qiov_request(src_cluster_offset + offset_in_cluster, qiov->size,
qiov, 0, &error_abort);
/*