aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2020-02-14 21:08:08 +0100
committerKevin Wolf <kwolf@redhat.com>2020-02-18 10:53:56 +0100
commitc5507b4d55f1f2989d3c108be387f62ed092ddc0 (patch)
tree65b9a68a80b59778b4092954092a8f10fb0b9438 /block
parentd71e65ec1d08849a4e62a778ed4ea732621cea26 (diff)
downloadqemu-c5507b4d55f1f2989d3c108be387f62ed092ddc0.zip
qemu-c5507b4d55f1f2989d3c108be387f62ed092ddc0.tar.gz
qemu-c5507b4d55f1f2989d3c108be387f62ed092ddc0.tar.bz2
commit: Fix argument order for block_job_error_action()
The block_job_error_action() error call in the commit job gives the on_err and is_read arguments in the wrong order. Fix this. (Of course, hard-coded is_read = false is wrong, too, but that's a separate problem for a separate patch.) Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-Id: <20200214200812.28180-4-kwolf@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/commit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/commit.c b/block/commit.c
index cce898a..8189f07 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -182,7 +182,7 @@ static int coroutine_fn commit_run(Job *job, Error **errp)
}
if (ret < 0) {
BlockErrorAction action =
- block_job_error_action(&s->common, false, s->on_error, -ret);
+ block_job_error_action(&s->common, s->on_error, false, -ret);
if (action == BLOCK_ERROR_ACTION_REPORT) {
goto out;
} else {