aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-08-14 08:27:39 +0200
committerFam Zheng <famz@redhat.com>2018-10-12 09:46:14 +0800
commit6388147296cd4c841a7d4409ba622c200332a8c7 (patch)
tree5b684d10720da6ae2e7eeefb595a02abb420cf37 /block
parent14a2d11825ddc37d6547a80704ae6450e9e376c7 (diff)
downloadqemu-6388147296cd4c841a7d4409ba622c200332a8c7.zip
qemu-6388147296cd4c841a7d4409ba622c200332a8c7.tar.gz
qemu-6388147296cd4c841a7d4409ba622c200332a8c7.tar.bz2
nvme: correct locking around completion
nvme_poll_queues is already protected by q->lock, and AIO callbacks are invoked outside the AioContext lock. So remove the acquire/release pair in nvme_handle_event. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20180814062739.19640-1-pbonzini@redhat.com> Signed-off-by: Fam Zheng <famz@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/nvme.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/block/nvme.c b/block/nvme.c
index 781d77d..2929403 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -489,10 +489,8 @@ static void nvme_handle_event(EventNotifier *n)
BDRVNVMeState *s = container_of(n, BDRVNVMeState, irq_notifier);
trace_nvme_handle_event(s);
- aio_context_acquire(s->aio_context);
event_notifier_test_and_clear(n);
nvme_poll_queues(s);
- aio_context_release(s->aio_context);
}
static bool nvme_add_io_queue(BlockDriverState *bs, Error **errp)