diff options
| author | Daniel P. Berrangé <berrange@redhat.com> | 2021-04-15 14:28:16 +0100 |
|---|---|---|
| committer | Daniel P. Berrangé <berrange@redhat.com> | 2021-06-14 13:28:50 +0100 |
| commit | 60ff2ae2a21ddc11cc7284194a3013ff864ac03c (patch) | |
| tree | 751d038c9cea0cf033a8c94e318ad3497ea8ea74 /block | |
| parent | c7ddc8821d88d958bb6d4ef1279ec3609b17ffda (diff) | |
| download | qemu-60ff2ae2a21ddc11cc7284194a3013ff864ac03c.zip qemu-60ff2ae2a21ddc11cc7284194a3013ff864ac03c.tar.gz qemu-60ff2ae2a21ddc11cc7284194a3013ff864ac03c.tar.bz2 | |
block: add trace point when fdatasync fails
A flush failure is a critical failure scenario for some operations.
For example, it will prevent migration from completing, as it will
make vm_stop() report an error. Thus it is important to have a
trace point present for debugging.
Reviewed-by: Connor Kuehl <ckuehl@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/file-posix.c | 2 | ||||
| -rw-r--r-- | block/trace-events | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/block/file-posix.c b/block/file-posix.c index 5ff78ec..4189b2b 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1338,6 +1338,8 @@ static int handle_aiocb_flush(void *opaque) ret = qemu_fdatasync(aiocb->aio_fildes); if (ret == -1) { + trace_file_flush_fdatasync_failed(errno); + /* There is no clear definition of the semantics of a failing fsync(), * so we may have to assume the worst. The sad truth is that this * assumption is correct for Linux. Some pages are now probably marked diff --git a/block/trace-events b/block/trace-events index 574760b..b3d2b1e 100644 --- a/block/trace-events +++ b/block/trace-events @@ -206,6 +206,7 @@ file_copy_file_range(void *bs, int src, int64_t src_off, int dst, int64_t dst_of file_FindEjectableOpticalMedia(const char *media) "Matching using %s" file_setup_cdrom(const char *partition) "Using %s as optical disc" file_hdev_is_sg(int type, int version) "SG device found: type=%d, version=%d" +file_flush_fdatasync_failed(int err) "errno %d" # ssh.c sftp_error(const char *op, const char *ssh_err, int ssh_err_code, int sftp_err_code) "%s failed: %s (libssh error code: %d, sftp error code: %d)" |