aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2020-06-17 14:21:56 +0100
committerStefan Hajnoczi <stefanha@redhat.com>2020-06-23 15:46:08 +0100
commitd38253cf8b44e3b94a5b327d014ab035ae1126ed (patch)
tree7bf997905bfd4a4533b601a89f5486e2a5294f6a /block
parent2446e0e2e9c9aaa5f8e8c7ef9a41fe8516054831 (diff)
downloadqemu-d38253cf8b44e3b94a5b327d014ab035ae1126ed.zip
qemu-d38253cf8b44e3b94a5b327d014ab035ae1126ed.tar.gz
qemu-d38253cf8b44e3b94a5b327d014ab035ae1126ed.tar.bz2
block/nvme: drop tautologous assertion
nvme_process_completion() explicitly checks cid so the assertion that follows is always true: if (cid == 0 || cid > NVME_QUEUE_SIZE) { ... continue; } assert(cid <= NVME_QUEUE_SIZE); Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Sergio Lopez <slp@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-id: 20200617132201.1832152-3-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/nvme.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/block/nvme.c b/block/nvme.c
index e4375ec..d567ece 100644
--- a/block/nvme.c
+++ b/block/nvme.c
@@ -336,7 +336,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q)
cid);
continue;
}
- assert(cid <= NVME_QUEUE_SIZE);
trace_nvme_complete_command(s, q->index, cid);
preq = &q->reqs[cid - 1];
req = *preq;