diff options
| author | Daniel Henrique Barboza <danielhb413@gmail.com> | 2020-01-30 18:39:04 -0300 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2020-03-11 15:54:38 +0100 |
| commit | 9bffae14df879255329473a7bd578643af2d4c9c (patch) | |
| tree | ff2386ef9e6f7150e2461059be9fbfca01e3ea23 /block | |
| parent | 6e1da96b946a1a38d3517564af4e2f572c3ccf4b (diff) | |
| download | qemu-9bffae14df879255329473a7bd578643af2d4c9c.zip qemu-9bffae14df879255329473a7bd578643af2d4c9c.tar.gz qemu-9bffae14df879255329473a7bd578643af2d4c9c.tar.bz2 | |
block: introducing 'bdrv_co_delete_file' interface
Adding to Block Drivers the capability of being able to clean up
its created files can be useful in certain situations. For the
LUKS driver, for instance, a failure in one of its authentication
steps can leave files in the host that weren't there before.
This patch adds the 'bdrv_co_delete_file' interface to block
drivers and add it to the 'file' driver in file-posix.c. The
implementation is given by 'raw_co_delete_file'.
Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20200130213907.2830642-2-danielhb413@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/file-posix.c | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/block/file-posix.c b/block/file-posix.c index 0f77447..9bc3838 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2445,6 +2445,28 @@ static int coroutine_fn raw_co_create_opts(const char *filename, QemuOpts *opts, return raw_co_create(&options, errp); } +static int coroutine_fn raw_co_delete_file(BlockDriverState *bs, + Error **errp) +{ + struct stat st; + int ret; + + if (!(stat(bs->filename, &st) == 0) || !S_ISREG(st.st_mode)) { + error_setg_errno(errp, ENOENT, "%s is not a regular file", + bs->filename); + return -ENOENT; + } + + ret = unlink(bs->filename); + if (ret < 0) { + ret = -errno; + error_setg_errno(errp, -ret, "Error when deleting file %s", + bs->filename); + } + + return ret; +} + /* * Find allocation range in @bs around offset @start. * May change underlying file descriptor's file offset. @@ -3075,6 +3097,7 @@ BlockDriver bdrv_file = { .bdrv_co_block_status = raw_co_block_status, .bdrv_co_invalidate_cache = raw_co_invalidate_cache, .bdrv_co_pwrite_zeroes = raw_co_pwrite_zeroes, + .bdrv_co_delete_file = raw_co_delete_file, .bdrv_co_preadv = raw_co_preadv, .bdrv_co_pwritev = raw_co_pwritev, |