aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2022-12-01 04:08:07 -0500
committerDaniel P. Berrangé <berrange@redhat.com>2023-02-15 11:01:04 -0500
commit610783cb6e47ccf0c3cde94dcb03dff2ae22107c (patch)
treefafe41f923d6c68092d09cb8a356b3411e9e480a /block
parentc3b3a6c9564bb00b0900600dc4cf965458589fd8 (diff)
downloadqemu-610783cb6e47ccf0c3cde94dcb03dff2ae22107c.zip
qemu-610783cb6e47ccf0c3cde94dcb03dff2ae22107c.tar.gz
qemu-610783cb6e47ccf0c3cde94dcb03dff2ae22107c.tar.bz2
block: deprecate iSCSI 'password' in favour of 'password-secret'
Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé <berrange@redhat.com> Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is overdue for deprecation and subsequent removal. Reviewed-by: Fabiano Rosas <farosas@suse.de> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/iscsi.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/block/iscsi.c b/block/iscsi.c
index b3e10f4..ed3e87a 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1353,6 +1353,9 @@ static void apply_chap(struct iscsi_context *iscsi, QemuOpts *opts,
} else if (!password) {
error_setg(errp, "CHAP username specified but no password was given");
return;
+ } else {
+ warn_report("iSCSI block driver 'password' option is deprecated, "
+ "use 'password-secret' instead");
}
if (iscsi_set_initiator_username_pwd(iscsi, user, password)) {