diff options
| author | Kevin Wolf <mail@kevin-wolf.de> | 2010-09-10 12:27:02 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2010-09-21 15:39:42 +0200 |
| commit | ac48e389d073bf2c8703745eef4824fabe0427ba (patch) | |
| tree | 9fa85d6bc3d664576bc25a27c2733d68b657c6ab /block | |
| parent | a287916c712b0c57a97cd35c663c5e7ba061bc7e (diff) | |
| download | qemu-ac48e389d073bf2c8703745eef4824fabe0427ba.zip qemu-ac48e389d073bf2c8703745eef4824fabe0427ba.tar.gz qemu-ac48e389d073bf2c8703745eef4824fabe0427ba.tar.bz2 | |
vvfat: Fix segfault on write to read-only disk
vvfat tries to set the readonly flag in its open function, but nowadays
this is overwritted with the readonly=... command line option. Check in
bdrv_write if the vvfat was opened read-only and return an error in this
case.
Without this check, vvfat tries to access the qcow bs, which is NULL
without enabled write support.
Signed-off-by: Kevin Wolf <mail@kevin-wolf.de>
Diffstat (limited to 'block')
| -rw-r--r-- | block/vvfat.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/block/vvfat.c b/block/vvfat.c index 365332a..5898d66 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2665,6 +2665,11 @@ static int vvfat_write(BlockDriverState *bs, int64_t sector_num, DLOG(checkpoint()); + /* Check if we're operating in read-only mode */ + if (s->qcow == NULL) { + return -EACCES; + } + vvfat_close_current_file(s); /* |