diff options
author | Stefano Garzarella <sgarzare@redhat.com> | 2023-07-25 12:37:44 +0200 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2023-07-25 15:34:17 -0400 |
commit | 9359c459889fce1804c4e1b2a2ff8f182b4a9ae8 (patch) | |
tree | 34c313ba6013d4c5e0407ae9ad23dc834ff994aa /block | |
parent | 66547f416a61e0cb711dc76821890242432ba193 (diff) | |
download | qemu-9359c459889fce1804c4e1b2a2ff8f182b4a9ae8.zip qemu-9359c459889fce1804c4e1b2a2ff8f182b4a9ae8.tar.gz qemu-9359c459889fce1804c4e1b2a2ff8f182b4a9ae8.tar.bz2 |
block/blkio: enable the completion eventfd
Until libblkio 1.3.0, virtio-blk drivers had completion eventfd
notifications enabled from the start, but from the next releases
this is no longer the case, so we have to explicitly enable them.
In fact, the libblkio documentation says they could be disabled,
so we should always enable them at the start if we want to be
sure to get completion eventfd notifications:
By default, the driver might not generate completion events for
requests so it is necessary to explicitly enable the completion
file descriptor before use:
void blkioq_set_completion_fd_enabled(struct blkioq *q, bool enable);
I discovered this while trying a development version of libblkio:
the guest kernel hangs during boot, while probing the device.
Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20230725103744.77343-1-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/blkio.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/block/blkio.c b/block/blkio.c index 1798648..bc1fac4 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -845,6 +845,7 @@ static int blkio_file_open(BlockDriverState *bs, QDict *options, int flags, QLIST_INIT(&s->bounce_bufs); s->blkioq = blkio_get_queue(s->blkio, 0); s->completion_fd = blkioq_get_completion_fd(s->blkioq); + blkioq_set_completion_fd_enabled(s->blkioq, true); blkio_attach_aio_context(bs, bdrv_get_aio_context(bs)); return 0; |