aboutsummaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2019-03-22 13:53:46 +0100
committerKevin Wolf <kwolf@redhat.com>2019-03-26 11:37:51 +0100
commit48ce986096bb70354b12f0becb253a06bcf9c434 (patch)
treea4d86945c69af3d2f6ed1454f49da332b6dc39e1 /block
parenta66c4b83c99c06626bed19ec0bf609bfe87a8cf3 (diff)
downloadqemu-48ce986096bb70354b12f0becb253a06bcf9c434.zip
qemu-48ce986096bb70354b12f0becb253a06bcf9c434.tar.gz
qemu-48ce986096bb70354b12f0becb253a06bcf9c434.tar.bz2
block: Remove error messages in bdrv_make_zero()
There is only a single caller of bdrv_make_zero(), which is qemu-img convert. If the function fails, we just fall back to a different method of zeroing out blocks on the target image. There is no good reason to print error messages on stderr when the higher level operation will actually succeed. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Acked-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'block')
-rw-r--r--block/io.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/block/io.c b/block/io.c
index 2ba603c..952372c 100644
--- a/block/io.c
+++ b/block/io.c
@@ -909,8 +909,6 @@ int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags flags)
}
ret = bdrv_block_status(bs, offset, bytes, &bytes, NULL, NULL);
if (ret < 0) {
- error_report("error getting block status at offset %" PRId64 ": %s",
- offset, strerror(-ret));
return ret;
}
if (ret & BDRV_BLOCK_ZERO) {
@@ -919,8 +917,6 @@ int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags flags)
}
ret = bdrv_pwrite_zeroes(child, offset, bytes, flags);
if (ret < 0) {
- error_report("error writing zeroes at offset %" PRId64 ": %s",
- offset, strerror(-ret));
return ret;
}
offset += bytes;