aboutsummaryrefslogtreecommitdiff
path: root/block/vvfat.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2014-05-28 11:16:55 +0200
committerKevin Wolf <kwolf@redhat.com>2014-05-30 14:26:54 +0200
commit75e347d66ab81944b5b657d17cc90ef92af3f016 (patch)
tree97758598e9d92e29175e675a52c1872ec4cc30c5 /block/vvfat.c
parentebee92b4fef9defa19a8c348ec8b2716732ad4df (diff)
downloadqemu-75e347d66ab81944b5b657d17cc90ef92af3f016.zip
qemu-75e347d66ab81944b5b657d17cc90ef92af3f016.tar.gz
qemu-75e347d66ab81944b5b657d17cc90ef92af3f016.tar.bz2
block/vvfat: Plug memory leak in enable_write_target()
I figure the leak originated in bdrv_create2(), and was duplicated into callers when commit 91a073a dropped that function. Looks like the other places have since been fixed. Spotted by Coverity. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Benoit Canet <benoit@irqsave.net> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/vvfat.c')
-rw-r--r--block/vvfat.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/block/vvfat.c b/block/vvfat.c
index 8f5114b..811b39c 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2929,6 +2929,7 @@ static int enable_write_target(BDRVVVFATState *s, Error **errp)
set_option_parameter(options, BLOCK_OPT_BACKING_FILE, "fat:");
ret = bdrv_create(bdrv_qcow, s->qcow_filename, options, errp);
+ free_option_parameters(options);
if (ret < 0) {
goto err;
}