diff options
| author | Max Reitz <mreitz@redhat.com> | 2019-02-01 20:29:05 +0100 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2019-02-25 15:11:25 +0100 |
| commit | f30c66ba6e417a07e68ad6e0bc5da27561a3beea (patch) | |
| tree | 4e0339c3e467478b24c6c4e740711394ffa27ba3 /block/raw-format.c | |
| parent | 83c68e149a9365a3db6de751f219ad1d79928462 (diff) | |
| download | qemu-f30c66ba6e417a07e68ad6e0bc5da27561a3beea.zip qemu-f30c66ba6e417a07e68ad6e0bc5da27561a3beea.tar.gz qemu-f30c66ba6e417a07e68ad6e0bc5da27561a3beea.tar.bz2 | |
block: Use bdrv_refresh_filename() to pull
Before this patch, bdrv_refresh_filename() is used in a pushing manner:
Whenever the BDS graph is modified, the parents of the modified edges
are supposed to be updated (recursively upwards). However, that is
nonviable, considering that we want child changes not to concern
parents.
Also, in the long run we want a pull model anyway: Here, we would have a
bdrv_filename() function which returns a BDS's filename, freshly
constructed.
This patch is an intermediate step. It adds bdrv_refresh_filename()
calls before every place a BDS.filename value is used. The only
exceptions are protocol drivers that use their own filename, which
clearly would not profit from refreshing that filename before.
Also, bdrv_get_encrypted_filename() is removed along the way (as a user
of BDS.filename), since it is completely unused.
In turn, all of the calls to bdrv_refresh_filename() before this patch
are removed, because we no longer have to call this function on graph
changes.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20190201192935.18394-2-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/raw-format.c')
| -rw-r--r-- | block/raw-format.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/block/raw-format.c b/block/raw-format.c index 6f6dc99..d07bcda 100644 --- a/block/raw-format.c +++ b/block/raw-format.c @@ -436,6 +436,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags, bs->file->bs->supported_zero_flags); if (bs->probed && !bdrv_is_read_only(bs)) { + bdrv_refresh_filename(bs->file->bs); fprintf(stderr, "WARNING: Image format was not specified for '%s' and probing " "guessed raw.\n" |