diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-02-03 16:21:50 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-02-23 19:49:17 +0100 |
| commit | b9b10c35e5c8bdb800601b142c44a4bd2da5a6d2 (patch) | |
| tree | d0f692507ec8ea696ecea07c1aae59a839568795 /block/preallocate.c | |
| parent | 7b1fb72e2c1b9fbca17c13b753aee25f445cad24 (diff) | |
| download | qemu-b9b10c35e5c8bdb800601b142c44a4bd2da5a6d2.zip qemu-b9b10c35e5c8bdb800601b142c44a4bd2da5a6d2.tar.gz qemu-b9b10c35e5c8bdb800601b142c44a4bd2da5a6d2.tar.bz2 | |
block: Mark public read/write functions GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_co_pread*/pwrite*() need to hold a reader lock for the graph.
For some places, we know that they will hold the lock, but we don't have
the GRAPH_RDLOCK annotations yet. In this case, add assume_graph_lock()
with a FIXME comment. These places will be removed once everything is
properly annotated.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230203152202.49054-12-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/preallocate.c')
| -rw-r--r-- | block/preallocate.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/block/preallocate.c b/block/preallocate.c index 91d73c8..63a2968 100644 --- a/block/preallocate.c +++ b/block/preallocate.c @@ -226,9 +226,10 @@ static void preallocate_reopen_abort(BDRVReopenState *state) state->opaque = NULL; } -static coroutine_fn int preallocate_co_preadv_part( - BlockDriverState *bs, int64_t offset, int64_t bytes, - QEMUIOVector *qiov, size_t qiov_offset, BdrvRequestFlags flags) +static int coroutine_fn GRAPH_RDLOCK +preallocate_co_preadv_part(BlockDriverState *bs, int64_t offset, int64_t bytes, + QEMUIOVector *qiov, size_t qiov_offset, + BdrvRequestFlags flags) { return bdrv_co_preadv_part(bs->file, offset, bytes, qiov, qiov_offset, flags); @@ -359,14 +360,11 @@ preallocate_co_pwrite_zeroes(BlockDriverState *bs, int64_t offset, return bdrv_co_pwrite_zeroes(bs->file, offset, bytes, flags); } -static coroutine_fn int preallocate_co_pwritev_part(BlockDriverState *bs, - int64_t offset, - int64_t bytes, - QEMUIOVector *qiov, - size_t qiov_offset, - BdrvRequestFlags flags) +static int coroutine_fn GRAPH_RDLOCK +preallocate_co_pwritev_part(BlockDriverState *bs, int64_t offset, int64_t bytes, + QEMUIOVector *qiov, size_t qiov_offset, + BdrvRequestFlags flags) { - assume_graph_lock(); /* FIXME */ handle_write(bs, offset, bytes, false); return bdrv_co_pwritev_part(bs->file, offset, bytes, qiov, qiov_offset, |