diff options
| author | Thomas Huth <thuth@redhat.com> | 2019-02-25 12:59:30 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2019-02-25 15:09:48 +0100 |
| commit | 83c68e149a9365a3db6de751f219ad1d79928462 (patch) | |
| tree | ec61e211e094ec3100de65479936b23a6f955678 /block/nvme.c | |
| parent | c1c43990846b89d740487d7022dce9415453f344 (diff) | |
| download | qemu-83c68e149a9365a3db6de751f219ad1d79928462.zip qemu-83c68e149a9365a3db6de751f219ad1d79928462.tar.gz qemu-83c68e149a9365a3db6de751f219ad1d79928462.tar.bz2 | |
block/nvme: Remove QEMU_PACKED from naturally aligned NVMeRegs struct
The QEMU_PACKED is causing a compiler warning/error with GCC 9:
CC block/nvme.o
block/nvme.c: In function ‘nvme_create_queue_pair’:
block/nvme.c:209:22: error: taking address of packed member of
‘struct <anonymous>’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
209 | q->sq.doorbell = &s->regs->doorbells[idx * 2 * s->doorbell_scale];
All members of the struct are naturally aligned, so there should
not be the need for QEMU_PACKED here, and the following QEMU_BUILD_BUG_ON
also ensures that there is no padding. Thus simply remove the QEMU_PACKED
here.
Buglink: https://bugs.launchpad.net/qemu/+bug/1817525
Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/nvme.c')
| -rw-r--r-- | block/nvme.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/nvme.c b/block/nvme.c index b5952c9..6c2ce7d 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -82,7 +82,7 @@ typedef volatile struct { uint8_t reserved1[0xec0]; uint8_t cmd_set_specfic[0x100]; uint32_t doorbells[]; -} QEMU_PACKED NVMeRegs; +} NVMeRegs; QEMU_BUILD_BUG_ON(offsetof(NVMeRegs, doorbells) != 0x1000); |