diff options
| author | Maxim Levitsky <mlevitsk@redhat.com> | 2020-03-26 03:12:18 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2020-03-26 14:44:33 +0100 |
| commit | 5a5e7f8cd86b7ced0732b1b6e28c82baa65b09c9 (patch) | |
| tree | 8b31bc0a2fc9cd2b25032ef51546035d8b38e78f /block/nvme.c | |
| parent | b92902dfeaafbceaf744ab7473f2d070284f6172 (diff) | |
| download | qemu-5a5e7f8cd86b7ced0732b1b6e28c82baa65b09c9.zip qemu-5a5e7f8cd86b7ced0732b1b6e28c82baa65b09c9.tar.gz qemu-5a5e7f8cd86b7ced0732b1b6e28c82baa65b09c9.tar.bz2 | |
block: trickle down the fallback image creation function use to the block drivers
Instead of checking the .bdrv_co_create_opts to see if we need the
fallback, just implement the .bdrv_co_create_opts in the drivers that
need it.
This way we don't break various places that need to know if the
underlying protocol/format really supports image creation, and this way
we still allow some drivers to not support image creation.
Fixes: fd17146cd93d1704cd96d7c2757b325fc7aac6fd
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1816007
Note that technically this driver reverts the image creation fallback
for the vxhs driver since I don't have a means to test it, and IMHO it
is better to leave it not supported as it was prior to generic image
creation patches.
Also drop iscsi_create_opts which was left accidentally.
Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20200326011218.29230-3-mlevitsk@redhat.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
[mreitz: Fixed alignment, and moved bdrv_co_create_opts_simple() and
bdrv_create_opts_simple from block.h into block_int.h]
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/nvme.c')
| -rw-r--r-- | block/nvme.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/block/nvme.c b/block/nvme.c index d41c4bd..7b7c0cc 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -1333,6 +1333,9 @@ static BlockDriver bdrv_nvme = { .protocol_name = "nvme", .instance_size = sizeof(BDRVNVMeState), + .bdrv_co_create_opts = bdrv_co_create_opts_simple, + .create_opts = &bdrv_create_opts_simple, + .bdrv_parse_filename = nvme_parse_filename, .bdrv_file_open = nvme_file_open, .bdrv_close = nvme_close, |