aboutsummaryrefslogtreecommitdiff
path: root/block/nbd-client.h
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2018-07-02 14:14:57 -0500
committerEric Blake <eblake@redhat.com>2018-07-02 15:27:38 -0500
commit216ee3657e14013505abe7853cecb632199fb13e (patch)
treee18e4865e721e7157c435e8dacd786918e300e0f /block/nbd-client.h
parentbacebdedbf921a2c641a34486ff543089d338f32 (diff)
downloadqemu-216ee3657e14013505abe7853cecb632199fb13e.zip
qemu-216ee3657e14013505abe7853cecb632199fb13e.tar.gz
qemu-216ee3657e14013505abe7853cecb632199fb13e.tar.bz2
nbd/client: Add x-dirty-bitmap to query bitmap from server
In order to test that the NBD server is properly advertising dirty bitmaps, we need a bare minimum client that can request and read the context. Since feature freeze for 3.0 is imminent, this is the smallest workable patch, which replaces the qemu block status report with the results of the NBD server's dirty bitmap (making it very easy to use 'qemu-img map --output=json' to learn where the dirty portions are). Note that the NBD protocol defines a dirty section with the same bit but opposite sense that normal "base:allocation" uses to report an allocated section; so in qemu-img map output, "data":true corresponds to clean, "data":false corresponds to dirty. A more complete solution that allows dirty bitmaps to be queried at the same time as normal block status will be required before this addition can lose the x- prefix. Until then, the fact that this replaces normal status with dirty status means actions like 'qemu-img convert' will likely misbehave due to treating dirty regions of the file as if they are unallocated. The next patch adds an iotest to exercise this new code. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20180702191458.28741-2-eblake@redhat.com>
Diffstat (limited to 'block/nbd-client.h')
-rw-r--r--block/nbd-client.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/block/nbd-client.h b/block/nbd-client.h
index 0ece76e..cfc9055 100644
--- a/block/nbd-client.h
+++ b/block/nbd-client.h
@@ -45,6 +45,7 @@ int nbd_client_init(BlockDriverState *bs,
const char *export_name,
QCryptoTLSCreds *tlscreds,
const char *hostname,
+ const char *x_dirty_bitmap,
Error **errp);
void nbd_client_close(BlockDriverState *bs);