diff options
| author | John Snow <jsnow@redhat.com> | 2016-10-27 12:06:58 -0400 |
|---|---|---|
| committer | Jeff Cody <jcody@redhat.com> | 2016-11-01 07:55:57 -0400 |
| commit | 8254b6d9534ba6a7d078a717e777fefe75ec27b6 (patch) | |
| tree | ddecba3c1b7004fa8bc8428128668da1f7497e57 /block/mirror.c | |
| parent | 47970dfb0a611f6468a0ba44781b4610525d1af1 (diff) | |
| download | qemu-8254b6d9534ba6a7d078a717e777fefe75ec27b6.zip qemu-8254b6d9534ba6a7d078a717e777fefe75ec27b6.tar.gz qemu-8254b6d9534ba6a7d078a717e777fefe75ec27b6.tar.bz2 | |
blockjob: centralize QMP event emissions
There's no reason to leave this to blockdev; we can do it in blockjobs
directly and get rid of an extra callback for most users.
All non-internal events, even those created outside of QMP, will
consistently emit events.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
Message-id: 1477584421-1399-5-git-send-email-jsnow@redhat.com
Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'block/mirror.c')
| -rw-r--r-- | block/mirror.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/block/mirror.c b/block/mirror.c index fa41849..aa60bcc 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1018,9 +1018,7 @@ void mirror_start(const char *job_id, BlockDriverState *bs, MirrorSyncMode mode, BlockMirrorBackingMode backing_mode, BlockdevOnError on_source_error, BlockdevOnError on_target_error, - bool unmap, - BlockCompletionFunc *cb, - void *opaque, Error **errp) + bool unmap, Error **errp) { bool is_none_mode; BlockDriverState *base; @@ -1033,7 +1031,7 @@ void mirror_start(const char *job_id, BlockDriverState *bs, base = mode == MIRROR_SYNC_MODE_TOP ? backing_bs(bs) : NULL; mirror_start_job(job_id, bs, BLOCK_JOB_DEFAULT, target, replaces, speed, granularity, buf_size, backing_mode, - on_source_error, on_target_error, unmap, cb, opaque, errp, + on_source_error, on_target_error, unmap, NULL, NULL, errp, &mirror_job_driver, is_none_mode, base, false); } |