diff options
| author | John Snow <jsnow@redhat.com> | 2018-08-29 21:57:27 -0400 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2018-08-31 16:28:33 +0200 |
| commit | 3d1f8b07a4c241f81949eff507d9f3a8fd73b87b (patch) | |
| tree | 7331c18b0a63be6b97cb783320d9cbff485f7f14 /block/mirror.c | |
| parent | f67432a2019caf05b57a146bf45c1024a5cb608e (diff) | |
| download | qemu-3d1f8b07a4c241f81949eff507d9f3a8fd73b87b.zip qemu-3d1f8b07a4c241f81949eff507d9f3a8fd73b87b.tar.gz qemu-3d1f8b07a4c241f81949eff507d9f3a8fd73b87b.tar.bz2 | |
jobs: canonize Error object
Jobs presently use both an Error object in the case of the create job,
and char strings in the case of generic errors elsewhere.
Unify the two paths as just j->err, and remove the extra argument from
job_completed. The integer error code for job_completed is kept for now,
to be removed shortly in a separate patch.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20180830015734.19765-3-jsnow@redhat.com
[mreitz: Dropped a superfluous g_strdup()]
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/mirror.c')
| -rw-r--r-- | block/mirror.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/mirror.c b/block/mirror.c index 691763d..be5dc6b 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -710,7 +710,7 @@ static void mirror_exit(Job *job, void *opaque) blk_insert_bs(bjob->blk, mirror_top_bs, &error_abort); bs_opaque->job = NULL; - job_completed(job, data->ret, NULL); + job_completed(job, data->ret); g_free(data); bdrv_drained_end(src); |