diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-09-29 16:51:53 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-10-12 16:31:33 +0200 |
| commit | 018f9dea9c905506c49f8f37c018470dddfc50f1 (patch) | |
| tree | 8eba2e1c435943d380b423301114ca415608d5b7 /block/iscsi.c | |
| parent | 277f2007ce187a6ff467579cb016824f80a2be10 (diff) | |
| download | qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.zip qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.tar.gz qemu-018f9dea9c905506c49f8f37c018470dddfc50f1.tar.bz2 | |
block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_apply_auto_read_only() need to hold a reader lock for the graph
because it calls bdrv_can_set_read_only(), which indirectly accesses the
parents list of a node.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20230929145157.45443-19-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/iscsi.c')
| -rw-r--r-- | block/iscsi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/block/iscsi.c b/block/iscsi.c index 5640c8b..2ff14b7 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1925,7 +1925,9 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, /* Check the write protect flag of the LUN if we want to write */ if (iscsilun->type == TYPE_DISK && (flags & BDRV_O_RDWR) && iscsilun->write_protected) { + bdrv_graph_rdlock_main_loop(); ret = bdrv_apply_auto_read_only(bs, "LUN is write protected", errp); + bdrv_graph_rdunlock_main_loop(); if (ret < 0) { goto out; } |