diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2022-12-07 14:18:38 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2022-12-15 16:08:23 +0100 |
| commit | 1b3ff9feb942c2ad0b01ac931e99ad451ab0ef39 (patch) | |
| tree | 858cc22574ca231ebc61c3e1cc90bcb69097d210 /block/io.c | |
| parent | 90830f595062ecf0d2c96049f5e01f3d37a2107f (diff) | |
| download | qemu-1b3ff9feb942c2ad0b01ac931e99ad451ab0ef39.zip qemu-1b3ff9feb942c2ad0b01ac931e99ad451ab0ef39.tar.gz qemu-1b3ff9feb942c2ad0b01ac931e99ad451ab0ef39.tar.bz2 | |
block: GRAPH_RDLOCK for functions only called by co_wrappers
The generated coroutine wrappers already take care to take the lock in
the non-coroutine path, and assume that the lock is already taken in the
coroutine path.
The only thing we need to do for the wrapped function is adding the
GRAPH_RDLOCK annotation. Doing so also allows us to mark the
corresponding callbacks in BlockDriver as GRAPH_RDLOCK_PTR.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20221207131838.239125-19-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/io.c')
| -rw-r--r-- | block/io.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -2697,6 +2697,7 @@ bdrv_co_readv_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos) BlockDriverState *child_bs = bdrv_primary_bs(bs); int ret; IO_CODE(); + assert_bdrv_graph_readable(); ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL); if (ret < 0) { @@ -2729,6 +2730,7 @@ bdrv_co_writev_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos) BlockDriverState *child_bs = bdrv_primary_bs(bs); int ret; IO_CODE(); + assert_bdrv_graph_readable(); ret = bdrv_check_qiov_request(pos, qiov->size, qiov, 0, NULL); if (ret < 0) { |