diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2019-07-22 17:44:27 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2019-08-16 10:25:16 +0200 |
| commit | d2da5e288a2e71e82866c8fdefd41b5727300124 (patch) | |
| tree | dc1fe8c9ec21fd5f96c92f348e4c87698b416b6f /block/commit.c | |
| parent | 421919d76b1755e1f9478f85cb71829ca5150ade (diff) | |
| download | qemu-d2da5e288a2e71e82866c8fdefd41b5727300124.zip qemu-d2da5e288a2e71e82866c8fdefd41b5727300124.tar.gz qemu-d2da5e288a2e71e82866c8fdefd41b5727300124.tar.bz2 | |
mirror: Keep mirror_top_bs drained after dropping permissions
mirror_top_bs is currently implicitly drained through its connection to
the source or the target node. However, the drain section for target_bs
ends early after moving mirror_top_bs from src to target_bs, so that
requests can already be restarted while mirror_top_bs is still present
in the chain, but has dropped all permissions and therefore runs into an
assertion failure like this:
qemu-system-x86_64: block/io.c:1634: bdrv_co_write_req_prepare:
Assertion `child->perm & BLK_PERM_WRITE' failed.
Keep mirror_top_bs drained until all graph changes have completed.
Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/commit.c')
0 files changed, 0 insertions, 0 deletions