diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2019-05-07 18:19:16 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2019-06-04 15:22:22 +0200 |
| commit | d0ee0204f400956ab429278f1b459d9af969c4a2 (patch) | |
| tree | 299f67c7b6969fc92ae02b40955b4eba0cd92a88 /block/commit.c | |
| parent | 8ed7d42fb528d380bb0fda1e91aa1770a1b05cf6 (diff) | |
| download | qemu-d0ee0204f400956ab429278f1b459d9af969c4a2.zip qemu-d0ee0204f400956ab429278f1b459d9af969c4a2.tar.gz qemu-d0ee0204f400956ab429278f1b459d9af969c4a2.tar.bz2 | |
block: Remove wrong bdrv_set_aio_context() calls
The mirror and commit block jobs use bdrv_set_aio_context() to move
their filter node into the right AioContext before hooking it up in the
graph. Similarly, bdrv_open_backing_file() explicitly moves the backing
file node into the right AioContext first.
This isn't necessary any more, they get automatically moved into the
right context now when attaching them.
However, in the case of bdrv_open_backing_file() with a node reference,
it's actually not only unnecessary, but even wrong: The unchecked
bdrv_set_aio_context() changes the AioContext of the child node even if
other parents require it to retain the old context. So this is not only
a simplification, but a bug fix, too.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1684342
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/commit.c')
| -rw-r--r-- | block/commit.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/block/commit.c b/block/commit.c index 4d51950..c815def 100644 --- a/block/commit.c +++ b/block/commit.c @@ -301,7 +301,6 @@ void commit_start(const char *job_id, BlockDriverState *bs, commit_top_bs->implicit = true; } commit_top_bs->total_sectors = top->total_sectors; - bdrv_set_aio_context(commit_top_bs, bdrv_get_aio_context(top)); bdrv_append(commit_top_bs, top, &local_err); if (local_err) { @@ -443,7 +442,6 @@ int bdrv_commit(BlockDriverState *bs) error_report_err(local_err); goto ro_cleanup; } - bdrv_set_aio_context(commit_top_bs, bdrv_get_aio_context(backing_file_bs)); bdrv_set_backing_hd(commit_top_bs, backing_file_bs, &error_abort); bdrv_set_backing_hd(bs, commit_top_bs, &error_abort); |