diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2021-05-17 12:05:45 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2021-05-21 18:22:33 +0100 |
| commit | eaee0720851f22b273099eaf4c02722d9f24340a (patch) | |
| tree | 4ffbc1e74cc8d43acf9a5c836f6ae51e56572bfd /block/block-copy.c | |
| parent | fb74a286feaa4ec2cdcda61ba570244464581ca7 (diff) | |
| download | qemu-eaee0720851f22b273099eaf4c02722d9f24340a.zip qemu-eaee0720851f22b273099eaf4c02722d9f24340a.tar.gz qemu-eaee0720851f22b273099eaf4c02722d9f24340a.tar.bz2 | |
coroutine-sleep: allow qemu_co_sleep_wake that wakes nothing
All callers of qemu_co_sleep_wake are checking whether they are passing
a NULL argument inside the pointer-to-pointer: do the check in
qemu_co_sleep_wake itself.
As a side effect, qemu_co_sleep_wake can be called more than once and
it will only wake the coroutine once; after the first time, the argument
will be set to NULL via *sleep_state->user_state_pointer. However, this
would not be safe unless co_sleep_cb keeps using the QemuCoSleepState*
directly, so make it go through the pointer-to-pointer instead.
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20210517100548.28806-4-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block/block-copy.c')
| -rw-r--r-- | block/block-copy.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/block-copy.c b/block/block-copy.c index 9b4af00..f896dc5 100644 --- a/block/block-copy.c +++ b/block/block-copy.c @@ -674,9 +674,7 @@ out: void block_copy_kick(BlockCopyCallState *call_state) { - if (call_state->sleep_state) { - qemu_co_sleep_wake(call_state->sleep_state); - } + qemu_co_sleep_wake(call_state->sleep_state); } /* |