diff options
| author | Max Reitz <mreitz@redhat.com> | 2020-05-13 13:05:36 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2020-05-18 19:05:25 +0200 |
| commit | b3af2af43b2bf85191cf40fa84b33df1268a08fd (patch) | |
| tree | 764c8dd694aaaafb665d09bf32722dd5bb652286 /block/blklogwrites.c | |
| parent | 8b1869daad17f313bf9a68fd3275448df0ecb7fb (diff) | |
| download | qemu-b3af2af43b2bf85191cf40fa84b33df1268a08fd.zip qemu-b3af2af43b2bf85191cf40fa84b33df1268a08fd.tar.gz qemu-b3af2af43b2bf85191cf40fa84b33df1268a08fd.tar.bz2 | |
block: Make filter drivers use child_of_bds
Note that some filters have secondary children, namely blkverify (the
image to be verified) and blklogwrites (the log). This patch does not
touch those children.
Note that for blkverify, the filtered child should not be format-probed.
While there is nothing enforcing this here, in practice, it will not be:
blkverify implements .bdrv_file_open. The block layer ensures (and in
fact, asserts) that BDRV_O_PROTOCOL is set for every BDS whose driver
implements .bdrv_file_open. This flag will then be bequeathed to
blkverify's children, and they will thus (by default) not be probed
either.
("By default" refers to the fact that blkverify's other child (the
non-filtered one) will have BDRV_O_PROTOCOL force-unset, because that is
what happens for all non-filtered children of non-format drivers.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200513110544.176672-27-mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/blklogwrites.c')
| -rw-r--r-- | block/blklogwrites.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block/blklogwrites.c b/block/blklogwrites.c index 4faf912..78b0c49 100644 --- a/block/blklogwrites.c +++ b/block/blklogwrites.c @@ -157,7 +157,8 @@ static int blk_log_writes_open(BlockDriverState *bs, QDict *options, int flags, } /* Open the file */ - bs->file = bdrv_open_child(NULL, options, "file", bs, &child_file, 0, false, + bs->file = bdrv_open_child(NULL, options, "file", bs, &child_of_bds, + BDRV_CHILD_FILTERED | BDRV_CHILD_PRIMARY, false, &local_err); if (local_err) { ret = -EINVAL; |