aboutsummaryrefslogtreecommitdiff
path: root/block.c
diff options
context:
space:
mode:
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>2020-03-24 18:59:21 +0300
committerKevin Wolf <kwolf@redhat.com>2020-03-27 14:47:23 +0100
commit7a26df203c7b2e4a585fc6014358b57a948fb7e0 (patch)
treefa6a2839af5ed9fc675f7ec0768f0388f233f77b /block.c
parent34afc5c298fd4b4279aeec440603b8a1a13ab8c2 (diff)
downloadqemu-7a26df203c7b2e4a585fc6014358b57a948fb7e0.zip
qemu-7a26df203c7b2e4a585fc6014358b57a948fb7e0.tar.gz
qemu-7a26df203c7b2e4a585fc6014358b57a948fb7e0.tar.bz2
block: fix bdrv_root_attach_child forget to unref child_bs
bdrv_root_attach_child promises to drop child_bs reference on failure. It does it on first handled failure path, but not on the second. Fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Message-Id: <20200324155921.23822-1-vsementsov@virtuozzo.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r--block.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/block.c b/block.c
index af3faf6..2e3905c 100644
--- a/block.c
+++ b/block.c
@@ -2617,6 +2617,7 @@ BdrvChild *bdrv_root_attach_child(BlockDriverState *child_bs,
error_propagate(errp, local_err);
g_free(child);
bdrv_abort_perm_update(child_bs);
+ bdrv_unref(child_bs);
return NULL;
}
}