aboutsummaryrefslogtreecommitdiff
path: root/block.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2023-09-29 16:51:52 +0200
committerKevin Wolf <kwolf@redhat.com>2023-10-12 16:31:33 +0200
commit277f2007ce187a6ff467579cb016824f80a2be10 (patch)
tree9e9a3b9921ce129649723140e17262c659f51ab0 /block.c
parent5155853e90388d9c8c5370bcbe1b6484a92ee710 (diff)
downloadqemu-277f2007ce187a6ff467579cb016824f80a2be10.zip
qemu-277f2007ce187a6ff467579cb016824f80a2be10.tar.gz
qemu-277f2007ce187a6ff467579cb016824f80a2be10.tar.bz2
block: Mark bdrv_op_is_blocked() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_op_is_blocked() need to hold a reader lock for the graph because it calls bdrv_get_device_or_node_name(), which accesses the parents list of a node. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-ID: <20230929145157.45443-18-kwolf@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r--block.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/block.c b/block.c
index d1a3466..fd348f5 100644
--- a/block.c
+++ b/block.c
@@ -7251,8 +7251,6 @@ bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp)
BdrvOpBlocker *blocker;
GLOBAL_STATE_CODE();
- assume_graph_lock(); /* FIXME */
-
assert((int) op >= 0 && op < BLOCK_OP_TYPE_MAX);
if (!QLIST_EMPTY(&bs->op_blockers[op])) {
blocker = QLIST_FIRST(&bs->op_blockers[op]);