diff options
author | Philippe Mathieu-Daudé <philmd@redhat.com> | 2020-04-22 15:31:44 +0200 |
---|---|---|
committer | Laurent Vivier <laurent@vivier.eu> | 2020-05-04 14:43:24 +0200 |
commit | dfde483ea38ce221e8e634823620308550b8f7f0 (patch) | |
tree | b1199c409ca4462e31719b2646aef5cce7cceccd /block.c | |
parent | b3ac2b94cdc939a90d5a22338ae507689e2cfab0 (diff) | |
download | qemu-dfde483ea38ce221e8e634823620308550b8f7f0.zip qemu-dfde483ea38ce221e8e634823620308550b8f7f0.tar.gz qemu-dfde483ea38ce221e8e634823620308550b8f7f0.tar.bz2 |
block: Avoid dead assignment
Fix warning reported by Clang static code analyzer:
block.c:3167:5: warning: Value stored to 'ret' is never read
ret = bdrv_fill_options(&options, filename, &flags, &local_err);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Fixes: 462f5bcf6
Reported-by: Clang Static Analyzer
Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20200422133152.16770-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'block.c')
-rw-r--r-- | block.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -3165,7 +3165,7 @@ static BlockDriverState *bdrv_open_inherit(const char *filename, } ret = bdrv_fill_options(&options, filename, &flags, &local_err); - if (local_err) { + if (ret < 0) { goto fail; } |