diff options
| author | Steve Sistare <steven.sistare@oracle.com> | 2023-06-07 08:18:36 -0700 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2023-06-13 11:28:58 +0200 |
| commit | b0182e537e5aba38031a5009cb16d5e924342458 (patch) | |
| tree | 67840f4419f12bc9de0005d2cbd0af316f2c4a3d /backends | |
| parent | 6fe4f6c941923608027e10af5dd30f18d481f9b9 (diff) | |
| download | qemu-b0182e537e5aba38031a5009cb16d5e924342458.zip qemu-b0182e537e5aba38031a5009cb16d5e924342458.tar.gz qemu-b0182e537e5aba38031a5009cb16d5e924342458.tar.bz2 | |
exec/memory: Introduce RAM_NAMED_FILE flag
migrate_ignore_shared() is an optimization that avoids copying memory
that is visible and can be mapped on the target. However, a
memory-backend-ram or a memory-backend-memfd block with the RAM_SHARED
flag set is not migrated when migrate_ignore_shared() is true. This is
wrong, because the block has no named backing store, and its contents will
be lost. To fix, ignore shared memory iff it is a named file. Define a
new flag RAM_NAMED_FILE to distinguish this case.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <1686151116-253260-1-git-send-email-steven.sistare@oracle.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Diffstat (limited to 'backends')
| -rw-r--r-- | backends/hostmem-file.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/backends/hostmem-file.c b/backends/hostmem-file.c index 38ea65b..b4335a8 100644 --- a/backends/hostmem-file.c +++ b/backends/hostmem-file.c @@ -57,6 +57,7 @@ file_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) ram_flags = backend->share ? RAM_SHARED : 0; ram_flags |= backend->reserve ? 0 : RAM_NORESERVE; ram_flags |= fb->is_pmem ? RAM_PMEM : 0; + ram_flags |= RAM_NAMED_FILE; memory_region_init_ram_from_file(&backend->mr, OBJECT(backend), name, backend->size, fb->align, ram_flags, fb->mem_path, fb->offset, fb->readonly, |