aboutsummaryrefslogtreecommitdiff
path: root/audio
diff options
context:
space:
mode:
authorVolker RĂ¼melin <vr_qemu@t-online.de>2020-04-05 09:50:15 +0200
committerGerd Hoffmann <kraxel@redhat.com>2020-04-06 13:29:53 +0200
commit4ba664cb0aabecfc425aa94cd025c515e6251539 (patch)
tree0caba46dea8c7e0b01e07dc9769cb638416e04c7 /audio
parent146aa0f104bb3bf88e43c4082a0bfc4bbda4fbd8 (diff)
downloadqemu-4ba664cb0aabecfc425aa94cd025c515e6251539.zip
qemu-4ba664cb0aabecfc425aa94cd025c515e6251539.tar.gz
qemu-4ba664cb0aabecfc425aa94cd025c515e6251539.tar.bz2
dsoundaudio: fix never-ending playback loop
Currently the DirectSound backend fails to stop audio playback in dsound_enable_out(). To detect a lost buffer condition dsound_get_status_out() incorrectly uses the error code DSERR_BUFFERLOST instead of flag DSBSTATUS_BUFFERLOST as a mask and returns with an error. As a result dsound_enable_out() returns early and doesn't stop playback. To reproduce the bug start qemu on a Windows host with -soundhw pcspk -audiodev dsound,id=audio0. On the guest FreeDOS 1.2 command line enter beep. The image Day 1 - F-Bird from the QEMU Advent Calendar 2018 shows the bug as well. Buglink: https://bugs.launchpad.net/qemu/+bug/1699628 Signed-off-by: Volker RĂ¼melin <vr_qemu@t-online.de> Message-id: 20200405075017.9901-1-vr_qemu@t-online.de Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'audio')
-rw-r--r--audio/dsoundaudio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/audio/dsoundaudio.c b/audio/dsoundaudio.c
index bd57082..9e621c8 100644
--- a/audio/dsoundaudio.c
+++ b/audio/dsoundaudio.c
@@ -279,7 +279,7 @@ static int dsound_get_status_out (LPDIRECTSOUNDBUFFER dsb, DWORD *statusp,
return -1;
}
- if (*statusp & DSERR_BUFFERLOST) {
+ if (*statusp & DSBSTATUS_BUFFERLOST) {
dsound_restore_out(dsb, s);
return -1;
}