diff options
| author | Juan Quintela <quintela@redhat.com> | 2014-02-11 22:56:00 +0100 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2014-02-25 14:26:59 +0100 |
| commit | aded6539d983280212e08d09f14157b1cb4d58cc (patch) | |
| tree | 97e39d71312ee29acfc1045fe4ae1c5268c81806 /arch_init.c | |
| parent | 0459650d94d18218808fcabc8c3227d2ee99af39 (diff) | |
| download | qemu-aded6539d983280212e08d09f14157b1cb4d58cc.zip qemu-aded6539d983280212e08d09f14157b1cb4d58cc.tar.gz qemu-aded6539d983280212e08d09f14157b1cb4d58cc.tar.bz2 | |
qemu_file: use fwrite() correctly
fwrite() returns the number of items written. But when there is one
error, it can return a short write.
In the particular bug that I was tracking, I did a migration to a
read-only filesystem. And it was able to finish the migration
correctly. fwrite() never returned a negative error code, nor zero,
always 4096. (migration writes chunks of about 14000 bytes). And it
was able to "complete" the migration with success (yes, reading the
file was a bit more difficult).
To add insult to injury, if your amount of memory was big enough (12GB
on my case), it overwrote some important structure, and from them,
malloc failed. This check makes the problem go away.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'arch_init.c')
0 files changed, 0 insertions, 0 deletions