aboutsummaryrefslogtreecommitdiff
path: root/alpha.ld
diff options
context:
space:
mode:
authorMichael Tokarev <mjt@tls.msk.ru>2012-03-12 21:28:06 +0400
committerMichael Tokarev <mjt@tls.msk.ru>2012-06-11 23:12:11 +0400
commit1b093c480a32051cc856b6ab2395d8cbc3ae99da (patch)
treed03f4e36bdeff34c4eaa4f2b8577bd501904370c /alpha.ld
parent03396148bca54c0e81ad8eecb12a136456d14c16 (diff)
downloadqemu-1b093c480a32051cc856b6ab2395d8cbc3ae99da.zip
qemu-1b093c480a32051cc856b6ab2395d8cbc3ae99da.tar.gz
qemu-1b093c480a32051cc856b6ab2395d8cbc3ae99da.tar.bz2
consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent
qemu_iovec_concat() is currently a wrapper for qemu_iovec_copy(), use the former (with extra "0" arg) in a few places where it is used. Change skip argument of qemu_iovec_copy() from uint64_t to size_t, since size of qiov itself is size_t, so there's no way to skip larger sizes. Rename it to soffset, to make it clear that the offset is applied to src. Also change the only usage of uint64_t in hw/9pfs/virtio-9p.c, in v9fs_init_qiov_from_pdu() - all callers of it actually uses size_t too, not uint64_t. One added restriction: as for all other iovec-related functions, soffset must point inside src. Order of argumens is already good: qemu_iovec_memset(QEMUIOVector *qiov, size_t offset, int c, size_t bytes) vs: qemu_iovec_concat(QEMUIOVector *dst, QEMUIOVector *src, size_t soffset, size_t sbytes) (note soffset is after _src_ not dst, since it applies to src; for memset it applies to qiov). Note that in many places where this function is used, the previous call is qemu_iovec_reset(), which means many callers actually want copy (replacing dst content), not concat. So we may want to add a wrapper like qemu_iovec_copy() with the same arguments but which calls qemu_iovec_reset() before _concat(). Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Diffstat (limited to 'alpha.ld')
0 files changed, 0 insertions, 0 deletions