aboutsummaryrefslogtreecommitdiff
path: root/accel/hvf
diff options
context:
space:
mode:
authorAlexander Graf <agraf@csgraf.de>2021-10-25 15:21:47 +0200
committerPaolo Bonzini <pbonzini@redhat.com>2021-11-02 15:57:27 +0100
commita443c3e225ea78f316f01a12a2fb1d55671e8256 (patch)
treeb5056e0000df7c5415a72cd6932fb780e2861995 /accel/hvf
parentff66ee53690abef92c1ea5c22b79e857cfa2485a (diff)
downloadqemu-a443c3e225ea78f316f01a12a2fb1d55671e8256.zip
qemu-a443c3e225ea78f316f01a12a2fb1d55671e8256.tar.gz
qemu-a443c3e225ea78f316f01a12a2fb1d55671e8256.tar.bz2
hvf: Avoid mapping regions < PAGE_SIZE as ram
HVF has generic memory listener code that adds all RAM regions as HVF RAM regions. However, HVF can only handle page aligned, page granule regions. So let's ignore regions that are not page aligned and sized. They will be trapped as MMIO instead. Signed-off-by: Alexander Graf <agraf@csgraf.de> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20211025132147.28308-1-agraf@csgraf.de> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'accel/hvf')
-rw-r--r--accel/hvf/hvf-accel-ops.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c
index 2b2c411..54457c7 100644
--- a/accel/hvf/hvf-accel-ops.c
+++ b/accel/hvf/hvf-accel-ops.c
@@ -122,6 +122,7 @@ static void hvf_set_phys_mem(MemoryRegionSection *section, bool add)
MemoryRegion *area = section->mr;
bool writeable = !area->readonly && !area->rom_device;
hv_memory_flags_t flags;
+ uint64_t page_size = qemu_real_host_page_size;
if (!memory_region_is_ram(area)) {
if (writeable) {
@@ -135,6 +136,12 @@ static void hvf_set_phys_mem(MemoryRegionSection *section, bool add)
}
}
+ if (!QEMU_IS_ALIGNED(int128_get64(section->size), page_size) ||
+ !QEMU_IS_ALIGNED(section->offset_within_address_space, page_size)) {
+ /* Not page aligned, so we can not map as RAM */
+ add = false;
+ }
+
mem = hvf_find_overlap_slot(
section->offset_within_address_space,
int128_get64(section->size));