diff options
author | Fam Zheng <famz@redhat.com> | 2015-06-08 13:56:10 +0800 |
---|---|---|
committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2015-07-29 21:46:07 -0500 |
commit | 3d8b7aed60e792bf2a9237cf689b13368f09ecc2 (patch) | |
tree | 5d0e3dd0b7d393c45655c408048fc72313d48991 /COPYING | |
parent | 27ed14c4d7decd359edb7fec0c8a39971ef32a72 (diff) | |
download | qemu-3d8b7aed60e792bf2a9237cf689b13368f09ecc2.zip qemu-3d8b7aed60e792bf2a9237cf689b13368f09ecc2.tar.gz qemu-3d8b7aed60e792bf2a9237cf689b13368f09ecc2.tar.bz2 |
block: Fix dirty bitmap in bdrv_co_discard
Unsetting dirty globally with discard is not very correct. The discard may zero
out sectors (depending on can_write_zeroes_with_unmap), we should replicate
this change to destination side to make sure that the guest sees the same data.
Calling bdrv_reset_dirty also troubles mirror job because the hbitmap iterator
doesn't expect unsetting of bits after current position.
So let's do it the opposite way which fixes both problems: set the dirty bits
if we are to discard it.
Reported-by: wangxiaolong@ucloud.cn
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit 508249952c0ea7472c62e17bf8132295dab4912d)
Conflicts:
block/io.c
* applied manually to avoid dependency on 61007b316
* squashed in 6e82e4b bdrv_reset_dirty() is static in
2.3.0 and becomes unused as of this patch
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'COPYING')
0 files changed, 0 insertions, 0 deletions