diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2024-08-13 17:52:46 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-08-20 00:38:48 +0200 |
| commit | 7d3a421feab29c03601813c8a0f98d5b2fd4420a (patch) | |
| tree | e8bca79dd8b3de393dd14c3bd604c99e1212c64c | |
| parent | dfad8421af474a38e272cdb19ae3c8e778acf820 (diff) | |
| download | qemu-7d3a421feab29c03601813c8a0f98d5b2fd4420a.zip qemu-7d3a421feab29c03601813c8a0f98d5b2fd4420a.tar.gz qemu-7d3a421feab29c03601813c8a0f98d5b2fd4420a.tar.bz2 | |
hw/remote/message.c: Don't directly invoke DeviceClass:reset
Directly invoking the DeviceClass::reset method is a bad idea,
because if the device is using three-phase reset then it relies on
transitional reset machinery which is likely to disappear at some
point.
Reset the device in the standard way, by calling device_cold_reset().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240813165250.2717650-7-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | hw/remote/message.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/hw/remote/message.c b/hw/remote/message.c index 50f6bf2..38ae6c7 100644 --- a/hw/remote/message.c +++ b/hw/remote/message.c @@ -215,13 +215,10 @@ fail: static void process_device_reset_msg(QIOChannel *ioc, PCIDevice *dev, Error **errp) { - DeviceClass *dc = DEVICE_GET_CLASS(dev); DeviceState *s = DEVICE(dev); MPQemuMsg ret = { 0 }; - if (dc->reset) { - dc->reset(s); - } + device_cold_reset(s); ret.cmd = MPQEMU_CMD_RET; |