diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2022-01-11 17:10:38 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2022-01-20 16:04:57 +0000 |
| commit | 7d62b2dcdb04fa625abb6600dbffd4464c3e4a85 (patch) | |
| tree | 1337bb2e2f1fab9dca5d6960190f2fa544f5595a | |
| parent | 905720f18d77e9ca8737d3ff047cad9079cbde6d (diff) | |
| download | qemu-7d62b2dcdb04fa625abb6600dbffd4464c3e4a85.zip qemu-7d62b2dcdb04fa625abb6600dbffd4464c3e4a85.tar.gz qemu-7d62b2dcdb04fa625abb6600dbffd4464c3e4a85.tar.bz2 | |
hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value
process_its_cmd() returns a bool, like all the other process_ functions.
However we were putting its return value into 'res', not 'result',
which meant we would ignore it when deciding whether to continue
or stall the command queue. Fix the typo.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220111171048.3545974-4-peter.maydell@linaro.org
| -rw-r--r-- | hw/intc/arm_gicv3_its.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c index 5919b1a..a6c2299 100644 --- a/hw/intc/arm_gicv3_its.c +++ b/hw/intc/arm_gicv3_its.c @@ -678,10 +678,10 @@ static void process_cmdq(GICv3ITSState *s) switch (cmd) { case GITS_CMD_INT: - res = process_its_cmd(s, data, cq_offset, INTERRUPT); + result = process_its_cmd(s, data, cq_offset, INTERRUPT); break; case GITS_CMD_CLEAR: - res = process_its_cmd(s, data, cq_offset, CLEAR); + result = process_its_cmd(s, data, cq_offset, CLEAR); break; case GITS_CMD_SYNC: /* |