diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2020-02-14 01:13:02 +0100 |
|---|---|---|
| committer | Richard Henderson <richard.henderson@linaro.org> | 2020-02-18 11:21:47 -0800 |
| commit | eb9b2ee8f68e1cb1f6b7cb6dee0c86492fae2f30 (patch) | |
| tree | a1e3768e3cfdee2ad432ca075a8cecea54fae3ed | |
| parent | b0f6455feac97e41045ee394e11c24d92c370f6e (diff) | |
| download | qemu-eb9b2ee8f68e1cb1f6b7cb6dee0c86492fae2f30.zip qemu-eb9b2ee8f68e1cb1f6b7cb6dee0c86492fae2f30.tar.gz qemu-eb9b2ee8f68e1cb1f6b7cb6dee0c86492fae2f30.tar.bz2 | |
hw/display/artist: Remove dead code (CID 1419388 & 1419389)
Coverity reports:
*** CID 1419388: Control flow issues (DEADCODE)
/hw/display/artist.c: 739 in draw_line_xy()
733 if (endy < 0) {
734 endy = 0;
735 }
736
737
738 if (endx < 0) {
>>> CID 1419388: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
739 return;
740 }
741
742 if (endy < 0) {
743 return;
744 }
*** CID 1419389: Control flow issues (DEADCODE)
/hw/display/artist.c: 743 in draw_line_xy()
737
738 if (endx < 0) {
739 return;
740 }
741
742 if (endy < 0) {
>>> CID 1419389: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "return;".
743 return;
744 }
745
746 trace_artist_draw_line(startx, starty, endx, endy);
747 draw_line(s, startx, starty, endx, endy, false, -1, -1);
748 }
Fixes: Covertiy CID 1419388 and 1419389 (commit 4765384ce33)
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Acked-by: Sven Schnelle <svens@stackframe.org>
Message-Id: <20200214001303.12873-6-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
| -rw-r--r-- | hw/display/artist.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/hw/display/artist.c b/hw/display/artist.c index 5492079..753dbb9 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -734,15 +734,6 @@ static void draw_line_xy(ARTISTState *s, bool update_start) endy = 0; } - - if (endx < 0) { - return; - } - - if (endy < 0) { - return; - } - draw_line(s, startx, starty, endx, endy, false, -1, -1); } |