aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEugenio Pérez <eperezma@redhat.com>2021-11-12 20:34:31 +0100
committerMichael S. Tsirkin <mst@redhat.com>2021-11-15 09:44:46 -0500
commitc829540401f280f0cad24131f4e7b92e81d506fa (patch)
treeaf36e591f21348c6c6b05587883b6ee353cb7e30
parent0351152b6f16e23e65407b4c4b27e23b46aa3801 (diff)
downloadqemu-c829540401f280f0cad24131f4e7b92e81d506fa.zip
qemu-c829540401f280f0cad24131f4e7b92e81d506fa.tar.gz
qemu-c829540401f280f0cad24131f4e7b92e81d506fa.tar.bz2
vdpa: Check for existence of opts.vhostdev
Since net_init_vhost_vdpa is trying to open it. Not specifying it in the command line crash qemu. Fixes: 7327813d17 ("vhost-vdpa: open device fd in net_init_vhost_vdpa()") Signed-off-by: Eugenio Pérez <eperezma@redhat.com> Message-Id: <20211112193431.2379298-3-eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--net/vhost-vdpa.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 1a7250b..2e3c22a 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -260,6 +260,10 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char *name,
assert(netdev->type == NET_CLIENT_DRIVER_VHOST_VDPA);
opts = &netdev->u.vhost_vdpa;
+ if (!opts->vhostdev) {
+ error_setg(errp, "vdpa character device not specified with vhostdev");
+ return -1;
+ }
vdpa_device_fd = qemu_open(opts->vhostdev, O_RDWR, errp);
if (vdpa_device_fd == -1) {