diff options
| author | David Hildenbrand <david@redhat.com> | 2019-10-21 10:57:12 +0200 |
|---|---|---|
| committer | Cornelia Huck <cohuck@redhat.com> | 2019-10-21 17:33:13 +0200 |
| commit | b57b336876d08e303d5957d05bae77508ed0e4a2 (patch) | |
| tree | 95ac36bc49eab3b4612335db2823de08f10a6815 | |
| parent | 8b952519478780ac26779018d3d7e9bf930d055a (diff) | |
| download | qemu-b57b336876d08e303d5957d05bae77508ed0e4a2.zip qemu-b57b336876d08e303d5957d05bae77508ed0e4a2.tar.gz qemu-b57b336876d08e303d5957d05bae77508ed0e4a2.tar.bz2 | |
s390x/tcg: Fix VECTOR SHIFT RIGHT ARITHMETIC BY BYTE
We forgot to propagate the highest bit accross the high doubleword in
two cases (shift >=64).
Fixes: 5f724887e3dd ("s390x/tcg: Implement VECTOR SHIFT RIGHT ARITHMETIC")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191021085715.3797-4-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
| -rw-r--r-- | target/s390x/vec_int_helper.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/target/s390x/vec_int_helper.c b/target/s390x/vec_int_helper.c index 1b3aaec..d384058 100644 --- a/target/s390x/vec_int_helper.c +++ b/target/s390x/vec_int_helper.c @@ -70,15 +70,17 @@ static void s390_vec_sar(S390Vector *d, const S390Vector *a, uint64_t count) d->doubleword[0] = a->doubleword[0]; d->doubleword[1] = a->doubleword[1]; } else if (count == 64) { + tmp = (int64_t)a->doubleword[0] >> 63; d->doubleword[1] = a->doubleword[0]; - d->doubleword[0] = 0; + d->doubleword[0] = tmp; } else if (count < 64) { tmp = a->doubleword[1] >> count; d->doubleword[1] = deposit64(tmp, 64 - count, count, a->doubleword[0]); d->doubleword[0] = (int64_t)a->doubleword[0] >> count; } else { + tmp = (int64_t)a->doubleword[0] >> 63; d->doubleword[1] = (int64_t)a->doubleword[0] >> (count - 64); - d->doubleword[0] = 0; + d->doubleword[0] = tmp; } } |