diff options
| author | Lukas Straub <lukasstraub2@web.de> | 2020-05-11 13:10:48 +0200 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2020-06-01 18:44:27 +0100 |
| commit | 786d8b8e38b134f99556e08047e016563b7063f9 (patch) | |
| tree | 7cbc54da4a9e0568da5489241423b41b4a9b3eba | |
| parent | bb70b66ed7a5600a63437fb6d64dedb44f670e58 (diff) | |
| download | qemu-786d8b8e38b134f99556e08047e016563b7063f9.zip qemu-786d8b8e38b134f99556e08047e016563b7063f9.tar.gz qemu-786d8b8e38b134f99556e08047e016563b7063f9.tar.bz2 | |
migration/colo.c: Use cpu_synchronize_all_states()
cpu_synchronize_all_pre_loadvm() marks all vcpus as dirty, so the
registers are loaded from CPUState before we continue running
the vm. However if we failover during checkpoint, CPUState is not
initialized and the registers are loaded with garbage. This causes
guest hangs and crashes.
Fix this by using cpu_synchronize_all_states(), which initializes
CPUState from the current cpu registers additionally to marking
the vcpus as dirty.
Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Message-Id: <9675031ce557b73ebd10e7bd20ebbf57f30b177c.1589193382.git.lukasstraub2@web.de>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
| -rw-r--r-- | migration/colo.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/migration/colo.c b/migration/colo.c index fe0d6e9..d00b3b9 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -705,7 +705,7 @@ static void colo_incoming_process_checkpoint(MigrationIncomingState *mis, } qemu_mutex_lock_iothread(); - cpu_synchronize_all_pre_loadvm(); + cpu_synchronize_all_states(); ret = qemu_loadvm_state_main(mis->from_src_file, mis); qemu_mutex_unlock_iothread(); |