diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2023-03-02 01:45:28 -0500 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2023-03-02 19:13:52 -0500 |
commit | ee92a56b08d0b59016a4a9bc1bf3a3de1fbe3956 (patch) | |
tree | f2eeb17e5a59811624de5c30f5f01d1eaa0bf690 | |
parent | e16add2b6b888faa2591de035b6cda5f5aef7ae7 (diff) | |
download | qemu-ee92a56b08d0b59016a4a9bc1bf3a3de1fbe3956.zip qemu-ee92a56b08d0b59016a4a9bc1bf3a3de1fbe3956.tar.gz qemu-ee92a56b08d0b59016a4a9bc1bf3a3de1fbe3956.tar.bz2 |
tests/data/acpi/virt: drop (most) duplicate files.
When virt ACPI files were added, lots of duplicates were created because
we forgot that there's a no-prefix fallback: e.g. if
tests/data/acpi/virt/APIC.memhp is not there then test will use
tests/data/acpi/virt/APIC.
Drop these.
These were found with
$find tests/data/acpi/ -type f -exec sha256sum '{}' ';'|sort -d|uniq -w 64 --all-repeated=separate
(trick: -d does a dictionary sort so a no-suffix file ends up first).
Note: there are still a bunch of issues with duplicates left even after this.
First pc and q35 are often identical.
Second, sometimes files are identical but not identical to the default
fallback, e.g.
tests/data/acpi/pc/SLIT.cphp and tests/data/acpi/pc/SLIT.memhp
or
tests/data/acpi/q35/HMAT.acpihmat-noinitiator and tests/data/acpi/virt/HMAT.acpihmatvirt
Finding a way to deduplicate these is still a TODO item - softlinks
maybe?
We also need to make rebuild-expected-aml.sh smarter about not creating
these duplicates in the 1st place.
And maybe we should use softlinks instead of relying on a fallback
to make it explicit what version does each test expect?
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r-- | tests/data/acpi/virt/APIC.memhp | bin | 172 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/APIC.numamem | bin | 172 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/DSDT.numamem | bin | 5196 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/FACP.memhp | bin | 276 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/FACP.numamem | bin | 276 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/GTDT.memhp | bin | 96 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/GTDT.numamem | bin | 96 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/IORT.memhp | bin | 128 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/IORT.numamem | bin | 128 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/IORT.pxb | bin | 128 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/MCFG.memhp | bin | 60 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/MCFG.numamem | bin | 60 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/SPCR.memhp | bin | 80 -> 0 bytes |
-rw-r--r-- | tests/data/acpi/virt/SPCR.numamem | bin | 80 -> 0 bytes |
14 files changed, 0 insertions, 0 deletions
diff --git a/tests/data/acpi/virt/APIC.memhp b/tests/data/acpi/virt/APIC.memhp Binary files differdeleted file mode 100644 index 179d274..0000000 --- a/tests/data/acpi/virt/APIC.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/APIC.numamem b/tests/data/acpi/virt/APIC.numamem Binary files differdeleted file mode 100644 index 179d274..0000000 --- a/tests/data/acpi/virt/APIC.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/DSDT.numamem b/tests/data/acpi/virt/DSDT.numamem Binary files differdeleted file mode 100644 index c475039..0000000 --- a/tests/data/acpi/virt/DSDT.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/FACP.memhp b/tests/data/acpi/virt/FACP.memhp Binary files differdeleted file mode 100644 index ac05c35..0000000 --- a/tests/data/acpi/virt/FACP.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/FACP.numamem b/tests/data/acpi/virt/FACP.numamem Binary files differdeleted file mode 100644 index ac05c35..0000000 --- a/tests/data/acpi/virt/FACP.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/GTDT.memhp b/tests/data/acpi/virt/GTDT.memhp Binary files differdeleted file mode 100644 index 6f8cb9b..0000000 --- a/tests/data/acpi/virt/GTDT.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/GTDT.numamem b/tests/data/acpi/virt/GTDT.numamem Binary files differdeleted file mode 100644 index 6f8cb9b..0000000 --- a/tests/data/acpi/virt/GTDT.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/IORT.memhp b/tests/data/acpi/virt/IORT.memhp Binary files differdeleted file mode 100644 index 7efd0ce..0000000 --- a/tests/data/acpi/virt/IORT.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/IORT.numamem b/tests/data/acpi/virt/IORT.numamem Binary files differdeleted file mode 100644 index 7efd0ce..0000000 --- a/tests/data/acpi/virt/IORT.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/IORT.pxb b/tests/data/acpi/virt/IORT.pxb Binary files differdeleted file mode 100644 index 7efd0ce..0000000 --- a/tests/data/acpi/virt/IORT.pxb +++ /dev/null diff --git a/tests/data/acpi/virt/MCFG.memhp b/tests/data/acpi/virt/MCFG.memhp Binary files differdeleted file mode 100644 index f4ae320..0000000 --- a/tests/data/acpi/virt/MCFG.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/MCFG.numamem b/tests/data/acpi/virt/MCFG.numamem Binary files differdeleted file mode 100644 index f4ae320..0000000 --- a/tests/data/acpi/virt/MCFG.numamem +++ /dev/null diff --git a/tests/data/acpi/virt/SPCR.memhp b/tests/data/acpi/virt/SPCR.memhp Binary files differdeleted file mode 100644 index 24e0a57..0000000 --- a/tests/data/acpi/virt/SPCR.memhp +++ /dev/null diff --git a/tests/data/acpi/virt/SPCR.numamem b/tests/data/acpi/virt/SPCR.numamem Binary files differdeleted file mode 100644 index 24e0a57..0000000 --- a/tests/data/acpi/virt/SPCR.numamem +++ /dev/null |