diff options
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | 2018-06-04 12:14:19 -0300 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2018-06-12 12:07:02 +0200 |
| commit | bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d (patch) | |
| tree | 900b4d02e11e439785bb558ce918060e91ecc6be | |
| parent | 649ae1040db656d5775f711e0dbea4c09c6c8fe9 (diff) | |
| download | qemu-bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d.zip qemu-bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d.tar.gz qemu-bf78fb1c1b61a819a47f7a1dbecf9934b9f32a0d.tar.bz2 | |
usb: correctly handle Zero Length Packets
USB Specification Revision 2.0, §5.5.3:
The Data stage of a control transfer from an endpoint to the host is complete when the endpoint does one of the following:
• Has transferred exactly the amount of data specified during the Setup stage
• Transfers a packet with a payload size less than wMaxPacketSize or transfers a zero-length packet"
hw/usb/redirect.c:802:9: warning: Declared variable-length array (VLA) has zero size
uint8_t buf[size];
^~~~~~~~~~~ ~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20180604151421.23385-2-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
| -rw-r--r-- | hw/usb/redirect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 65a9196..58e8f7f 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -795,7 +795,7 @@ static void usbredir_handle_bulk_data(USBRedirDevice *dev, USBPacket *p, usbredirparser_peer_has_cap(dev->parser, usb_redir_cap_32bits_bulk_length)); - if (ep & USB_DIR_IN) { + if (ep & USB_DIR_IN || size == 0) { usbredirparser_send_bulk_packet(dev->parser, p->id, &bulk_packet, NULL, 0); } else { |